Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ui-events.js. (winp) #24

Closed
wants to merge 1 commit into from
Closed

Create ui-events.js. (winp) #24

wants to merge 1 commit into from

Conversation

escher-m
Copy link

@escher-m escher-m commented Apr 29, 2020 •
edited
Loading

for adding spinner during compiling

-Team BigUhOh (RGSoC '20)

@escher-m escher-m changed the title Create ui-events.js Create ui-events.js. (winp) Apr 29, 2020
@poush poush requested review from jainaman224 and shashaBot April 30, 2020 09:15
shashaBot
shashaBot reviewed May 1, 2020
View reviewed changes
Copy link
Collaborator

@shashaBot shashaBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JavaScript code fails with SyntaxError. Also, you don't need to create a new event. Just listen for the onclick event.

@shashaBot
Copy link
Collaborator

Closing this PR, please make required changes and include them in #25 itself.

@shashaBot shashaBot closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashaBot shashaBot shashaBot left review comments

@jainaman224 jainaman224 Awaiting requested review from jainaman224

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escher-m @shashaBot