Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

97 clean up predicate comparison relations #138

Merged
merged 9 commits into from
May 6, 2024
Merged

97 clean up predicate comparison relations #138

merged 9 commits into from
May 6, 2024

Commits on May 5, 2024

  1. Main change to the semantics of Predicate comparison 

    Predicate comparison now uses the underlying clingo.Symbol object. Will allow querying with
ordering to work even when the types are incomparable because Symbol objects are always
comparable.

Still needs to update some of the querying behaviour
    @daveraja
    daveraja committed May 5, 2024
    Configuration menu
    Copy the full SHA
    fd30945 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Updated comparison semantics - passing all tests

    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2f0dc21 View commit details
    Browse the repository at this point in the history

  2. Update documentation for comparison operator change

    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b7dc53d View commit details
    Browse the repository at this point in the history

  3. Added example of FactBase.asp_str(sorted=True)

    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    87f0e0a View commit details
    Browse the repository at this point in the history

  4. Black/isort formatting fixes

    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    49d4d3a View commit details
    Browse the repository at this point in the history

  5. Some reformatting and cleaning up

    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ee74651 View commit details
    Browse the repository at this point in the history

  6. Update minimum Python version and update workflow

    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    479775e View commit details
    Browse the repository at this point in the history

  7. Update version to 1.6.0

    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3a6ca8c View commit details
    Browse the repository at this point in the history

  8. Remove abc.ABCMeta derivation of Predicate 

    I think this is causing a problem with Python <= 3.10 when specifying
Predicate with a "name" argument.
    @daveraja
    daveraja committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e648a6d View commit details
    Browse the repository at this point in the history