formatting all variables with trailing _<SORT> for TPTP compliance #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eplacing $i, $s convention)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(replacing $i, $s convention).
The formula "forall X exists X$ p(X,X$)" is legal in our FOL syntax tree and custom control language. But TPTP doesn't have a sort identifier in variables, resulting in the ambiguous formula "![X: general, X: $int]: p(X,X)." This issue prompted printing variables with sort identifiers for non-general variables, e.g. "![X: general, X$i: $int]: p(X,X$i)." Which Vampire accepts, but TPTP in general does not (according to TPTP4X trials). So now I replaced the "$" with an "_" and made ALL variables (including general variables) append an _. Otherwise "forall X_i exists X$ p(X_i,X$)" would be formatted ambiguously: "![X_i: general, X_i: $int]: p(X_i,X_i)."
Closes #166