Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the featured Homebridge plugin to a more recent and maintained one. #2281

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

maxileith
Copy link
Contributor

Hi @postlund ,

I am currently developing a homebridge plugin that is already in a very solid state. I would suggest to replace the currently featured but not maintained homebridge plugin (seems like it when looking at the open issues) from @cristian5th with this maintained one. Also my plugin is more native, since it does not provide a configuration for another homebridge plugin but is a homebridge plugin by itself.

@cristian5th you are welcome to join the discussion

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2da50e9) 88.90% compared to head (9d7b9eb) 88.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2281      +/-   ##
==========================================
- Coverage   88.90%   88.82%   -0.09%     
==========================================
  Files         168      168              
  Lines       11370    11370              
==========================================
- Hits        10109    10099      -10     
- Misses       1261     1271      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristian5th
Copy link

Hi @maxileith.

That’s very good news. I agree if @postlund replaces the link to my shell script with a link to your real plugin. It will be much better.

I’m actually not using Homebridge anymore due to many issues with other plugins.

@postlund
Copy link
Owner

This makes sense to me, thanks for updating and your work on the updated homebridge plugin! 👍

@postlund postlund merged commit 8be2b64 into postlund:master Dec 17, 2023
17 of 18 checks passed
@maxileith maxileith deleted the featureHomebridgePlugin branch December 17, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants