refactor: optimize overall performance

.eslintrc.json

@@ -31,8 +31,8 @@
     "max-len": ["error", 80],
     "arrow-parens": 0,
     "comma-dangle": [2, "only-multiline"],
-    "prefer-reflect": 2,
     "global-require": 0,
+    "operator-assignment": 0,
     "class-methods-use-this": 0,
     "no-restricted-syntax": [
       "error",

bin/lux

@@ -35,9 +35,9 @@ function commandNotFound(cmd) {
 
 function setEnvVar(key, val, def) {
   if (val) {
-    Reflect.set(process.env, key, val);
-  } else if (!Reflect.has(process.env, key)) {
-    Reflect.set(process.env, key, def);
+    process.env[key] = val;
+  } else if (!process.env[key]) {
+    process.env[key] = def;
   }
 }
 

src/constants.js

@@ -23,3 +23,4 @@ export const LUX_CONSOLE = ENV.LUX_CONSOLE || false;
 export const PLATFORM = platform();
 export const CIRCLECI = ENV.CIRCLECI;
 export const APPVEYOR = ENV.APPVEYOR;
+export const IS_PRODUCTION = NODE_ENV === 'production';

src/interfaces.js

@@ -13,3 +13,23 @@ export interface Chain<T> {
   value(): T;
   construct<U, V: Class<U>>(constructor: V): Chain<U>;
 }
+
+export type ObjectMap<K, V> = {
+  [key: K]: V;
+};
+
+export interface Thenable<+R> {
+  constructor(callback: (
+    resolve: (result: Promise<R> | R) => void,
+    reject:  (error: any) => void
+  ) => mixed): void;
+
+  then<U>(
+    onFulfill?: (value: R) => Promise<U> | U,
+    onReject?: (error: any) => Promise<U> | U
+  ): Promise<U>;
+
+  catch<U>(
+    onReject?: (error: any) => ?Promise<U> | U
+  ): Promise<U>;
+}

src/packages/application/index.js

@@ -88,7 +88,7 @@ class Application {
    * @type {Map}
    * @private
    */
-  controllers: FreezeableMap<string, Controller>;
+  controllers: FreezeableMap<string, Controller<*>>;
 
   /**
    * A map containing each `Serializer` instance.

src/packages/application/initialize.js

@@ -48,7 +48,7 @@ export default async function initialize<T: Application>(app: T, {
   );
 
   models.forEach(model => {
-    Reflect.defineProperty(model, 'serializer', {
+    Object.defineProperty(model, 'serializer', {
       value: closestChild(serializers, model.resourceName),
       writable: false,
       enumerable: false,
@@ -67,7 +67,7 @@ export default async function initialize<T: Application>(app: T, {
   );
 
   controllers.forEach(controller => {
-    Reflect.defineProperty(controller, 'controllers', {
+    Object.defineProperty(controller, 'controllers', {
       value: controllers,
       writable: true,
       enumerable: false,

src/packages/application/interfaces.js

@@ -10,7 +10,7 @@ export type Application$opts = Config & {
   database: Database$config;
 };
 
-export type Application$factoryOpts<T: Controller | Serializer<*>> = {
+export type Application$factoryOpts<T: Controller<*> | Serializer<*>> = {
   key: string;
   store: Database;
   parent: ?T;

src/packages/application/utils/create-controller.js

@@ -9,12 +9,12 @@ import type Controller from '../../controller';
 import type Serializer from '../../serializer';
 import type { Bundle$Namespace } from '../../loader'; // eslint-disable-line max-len, no-duplicate-imports
 
-export default function createController<T: Controller>(
+export default function createController<T: Controller<*>>(
   constructor: Class<T>,
   opts: {
     key: string;
     store: Database;
-    parent: ?Controller;
+    parent: ?Controller<*>;
     serializers: Bundle$Namespace<Serializer<*>>;
   }
 ): T {
@@ -36,11 +36,11 @@ export default function createController<T: Controller>(
     serializer = closestAncestor(serializers, key);
   }
 
-  const instance: T = Reflect.construct(constructor, [{
+  const instance: T = new constructor({
     model,
     namespace,
     serializer
-  }]);
+  });
 
   if (serializer) {
     if (!instance.filter.length) {
@@ -64,7 +64,7 @@ export default function createController<T: Controller>(
     ];
   }
 
-  Reflect.defineProperty(instance, 'parent', {
+  Object.defineProperty(instance, 'parent', {
     value: parent,
     writable: false,
     enumerable: true,

src/packages/application/utils/create-serializer.js

@@ -23,13 +23,13 @@ export default function createSerializer<T: Serializer<*>>(
     parent = null;
   }
 
-  const instance: T = Reflect.construct(constructor, [{
+  const instance: T = new constructor({
     model,
     parent,
     namespace
-  }]);
+  });
 
-  Reflect.defineProperty(instance, 'parent', {
+  Object.defineProperty(instance, 'parent', {
     value: parent,
     writable: false,
     enumerable: true,

src/packages/cli/commands/dbcreate.js

@@ -13,7 +13,7 @@ import { createLoader } from '../../loader';
  */
 export function dbcreate() {
   const load = createLoader(CWD);
-  const config = Reflect.get(load('config').database, NODE_ENV);
+  const config = load('config').database[NODE_ENV];
 
   if (!config) {
     throw new DatabaseConfigMissingError(NODE_ENV);

src/packages/cli/commands/dbdrop.js

@@ -13,7 +13,7 @@ import { createLoader } from '../../loader';
  */
 export function dbdrop() {
   const load = createLoader(CWD);
-  const config = Reflect.get(load('config').database, NODE_ENV);
+  const config = load('config').database[NODE_ENV];
 
   if (!config) {
     throw new DatabaseConfigMissingError(NODE_ENV);

src/packages/cli/commands/repl.js

@@ -7,9 +7,8 @@ import type Application from '../../application';
 
 export function repl(): Promise<void> {
   return new Promise(async (resolve) => {
-    const app: Application = await Reflect.apply(require, null, [
-      path.join(CWD, 'dist', 'boot')
-    ]);
+    // $FlowIgnore
+    const app: Application = require(path.join(CWD, 'dist', 'boot'));
 
     const instance = startRepl({
       prompt: '> '

src/packages/cli/commands/serve.js

@@ -24,6 +24,7 @@ export async function serve({
   const load = createLoader(CWD);
   const { logging } = load('config');
   const logger = new Logger(logging);
+  let maxWorkers;
 
   if (hot) {
     const watcher = await watch(CWD);
@@ -34,11 +35,15 @@ export async function serve({
     });
   }
 
+  if (!cluster) {
+    maxWorkers = 1;
+  }
+
   createCluster({
     logger,
+    maxWorkers,
     path: CWD,
-    port: PORT,
-    maxWorkers: cluster ? undefined : 1
+    port: PORT
   }).once('ready', () => {
     logger.info(`Lux Server listening on port: ${cyan(`${PORT}`)}`);
   });

src/packages/cli/generator/utils/generator-for.js

@@ -5,7 +5,7 @@ import * as generators from './generate-type';
 
 export default function generatorFor(type: string): Generator {
   const normalized = type.toLowerCase();
-  const generator: void | Generator = Reflect.get(generators, normalized);
+  const generator: void | Generator = generators[normalized];
 
   if (!generator) {
     throw new Error(`Could not find a generator for '${type}'.`);

src/packages/cli/templates/model.js

@@ -35,7 +35,7 @@ export default (name: string, attrs: Array<string>) => {
           .pipe(str => camelize(str, true))
           .value();
 
-        const value = Reflect.get(types, key);
+        const value = types[key];
 
         if (value) {
           const inverse = camelize(normalized, true);

src/packages/compiler/utils/config.js

@@ -0,0 +1,32 @@
+// @flow
+import merge from '../../../utils/merge';
+
+const IGNORE_WARNING = /^treating '.+' as external dependency$/i;
+
+export function createRollupConfig<T: Object>(options: T): T {
+  return merge({
+    acorn: {
+      sourceType: 'module',
+      ecmaVersion: 2017,
+      allowReserved: true,
+      preserveParens: true
+    },
+    entry: '',
+    onwarn: warning => {
+      if (IGNORE_WARNING.test(warning)) {
+        return;
+      }
+
+      process.stderr.write(`${warning}\n`);
+    },
+    preferConst: true
+  }, options);
+}
+
+export function createBundleConfig<T: Object>(options: T): T {
+  return merge({
+    format: 'cjs',
+    sourceMap: true,
+    useStrict: false
+  }, options);
+}

src/packages/compiler/utils/create-manifest.js

@@ -106,7 +106,7 @@ export default async function createManifest(
     Array
       .from(assets)
       .map(([key, value]) => {
-        const write = Reflect.get(writer, key);
+        const write = writer[key];
 
         if (write) {
           return write(value);