build: update linter config and remove deprecated linters

.golangci.yaml

@@ -27,16 +27,21 @@ linters-settings:
       - hugeParam
   gocyclo:
     min-complexity: 15
-  golint:
+  revive:
     min-confidence: 0.8
   govet:
     check-shadowing: true
   lll:
     line-length: 140
-  maligned:
-    suggest-new: true
   misspell:
     locale: US
+  nolintlint:
+    allow-leading-space: false
+    require-explanation: true
+    allow-no-explanation:
+      - gocognit
+      - funlen
+      - gocyclo
 
 linters:
   disable-all: true
@@ -48,29 +53,26 @@ linters:
     - dupl
     - errcheck
     - funlen
-    # - gochecknoglobals
+    - nolintlint
+    - gochecknoglobals
     - gochecknoinits
     - gocognit
     - goconst
     - gocritic
     - gocyclo
-    # - godox
     - gofmt
     - goimports
-    - golint
+    - revive
     - goprintffuncname
     - gosec
     - gosimple
     - govet
     - ineffassign
-    - interfacer
-    # - lll
-    - maligned
     - misspell
     - nakedret
     - prealloc
     - rowserrcheck
-    - scopelint
+    - exportloopref
     - staticcheck
     - structcheck
     - stylecheck
@@ -81,7 +83,6 @@ linters:
     - varcheck
     - whitespace
     - wsl
-
 issues:
   exclude:
     # Very commonly not checked.

cmd/kuota-calc.go

@@ -16,7 +16,7 @@ import (
 	"k8s.io/cli-runtime/pkg/genericclioptions"
 )
 
-var (
+const (
 	kuotaCalcExample = `    # provide a simple/complex deployment by piping it to kuota-calc (used as kubectl plugin)
     cat deployment.yaml | kubectl %[1]s
 

main.go

@@ -8,9 +8,8 @@ import (
 	"k8s.io/cli-runtime/pkg/genericclioptions"
 )
 
-//nolint:gochecknoglobals
+//nolint:gochecknoglobals // Set by goreleaser on build
 var (
-	// set by goreleaser on build
 	version, date, commit string = "master", "?", "?"
 )