Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/july improvements #152

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Feat/july improvements #152

merged 10 commits into from
Jul 23, 2024

Conversation

clementnuss
Copy link
Contributor

No description provided.

permits to simplify the code makes way for a programmatic
modification of the result fields.

Signed-off-by: Clément Nussbaumer <[email protected]>
Signed-off-by: Clément Nussbaumer <[email protected]>
closes #148

Signed-off-by: Clément Nussbaumer <[email protected]>
closes: #147
Signed-off-by: Clément Nussbaumer <[email protected]>
Signed-off-by: Clément Nussbaumer <[email protected]>
@coveralls
Copy link

coveralls commented Jul 23, 2024

Pull Request Test Coverage Report for Build 10056483097

Details

  • 83 of 118 (70.34%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 62.222%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/servicecheck/transport.go 3 6 50.0%
main.go 0 3 0.0%
internal/kubenurse/server.go 23 28 82.14%
internal/servicecheck/httptrace.go 1 6 16.67%
internal/kubenurse/handler.go 2 8 25.0%
internal/servicecheck/servicecheck.go 53 66 80.3%
Files with Coverage Reduction New Missed Lines %
internal/servicecheck/servicecheck.go 1 85.83%
Totals Coverage Status
Change from base Build 10007923840: -0.2%
Covered Lines: 448
Relevant Lines: 720

💛 - Coveralls

@clementnuss clementnuss merged commit 12281da into main Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants