fix: do not reuse connections per default #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stop reusing connections per default, by modifying the http.Transport DisableKeepAlive field to true per default. Can be overriden through setting KUBENURSE_REUSE_CONNECTIONS env var to "true" Signed-off-by: Clément Nussbaumer <[email protected]>
clementnuss
force-pushed
the
cjmn-patch-2a0d
branch
from
99f288b to
47f274a
Compare
|
@zbindenren @djboris9 what do you think ? the effect on the number of open file descriptor/goroutines is really interesting. the http request duration also starts to be more interesting ! do you agree that this mode should be the default ? 
|
Signed-off-by: Clément Nussbaumer <[email protected]>
Signed-off-by: Clément Nussbaumer <[email protected]>
clementnuss
force-pushed
the
cjmn-patch-2a0d
branch
from
47f274a to
4113065
Compare
Pull Request Test Coverage Report for Build 7584865362
💛 - Coveralls |
Signed-off-by: Clément Nussbaumer <[email protected]>
@clementnuss LGTM 👍 |
the default configuration changes: now kubenurse will NOT reuse connections per default. this permits to have a clearer picture, as closed long-lived connections might not involve DNS resolution, and might hide Load balancer pool problems. Signed-off-by: Clément Nussbaumer <[email protected]>
clementnuss
force-pushed
the
cjmn-patch-2a0d
branch
from
a0222b8 to
9cb33d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop reusing connections per default, by modifying the http.Transport DisableKeepAlive field to true per default. Can be overriden through setting KUBENURSE_REUSE_CONNECTIONS env var to "true"
This will be a minor change, as the results and behaviour of Kubenurse is modified consequently.