Fix graceful shutdown #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will already help prevent false positives from other kubenurse pods when trying to reach me_ingress through the ingress controller during teardown. without this 5sec wait, in-flight requests from e.g. the ingress controller will reach a pod that is already terminated. Might not be sufficient for similar for "path" errors, as there is no filter for terminating pods. Signed-off-by: Clément Nussbaumer <[email protected]>
during the first start of kubenurse, if the ingress isn't ready yet or if kubenurse makes a check before a kubenurse pod is actually ready, this will result in errors in the logs and this will prevent the pipeline from working correctly. Signed-off-by: Clément Nussbaumer <[email protected]>
Signed-off-by: Clément Nussbaumer <[email protected]>
prevents false positive path_error when checks are made to pending or terminating pods Signed-off-by: Clément Nussbaumer <[email protected]>
Pull Request Test Coverage Report for Build 7207008932
💛 - Coveralls |
Signed-off-by: Clément Nussbaumer <[email protected]>
Signed-off-by: Clément Nussbaumer <[email protected]>
clementnuss
force-pushed
the
fix-graceful-shutdown
branch
from
e8d6264 to
461bda5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that kubenurse was:
SIGTERMthen the http server shuts down almost immediately).In Kubenurse shutdown scenarios, this lead to erroneous
me_ingresserrors (i.e. when the pod has already closed its http server, but the ingress-nginx still has an inflight request that then timeouts), and to to falsepath_<node>errors as well, as terminating pods were still receiving queries.together with that I fixed the build script a little 🙃