Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix \cvsubentry not compiling while description had any content. #524

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miguelandres
Copy link

@miguelandres miguelandres commented Jun 19, 2024

I rewrote its implementation and made it compile, and uncommented the code that exposed it in the examples, adding some dummy description data to expose the previously untested issues.

This solves #297 and #29 (which seemed to have been closed even though some still had issues with cv subentry)

First, I simplified the `\cvsubentry` command to only take three arguments: the position you held, the dates you held it, and the description.

Then I simplified its implementation and made it compile
@github-actions github-actions bot added the size/S Small size issue or PR. label Jun 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome! Looks like this is your first pull request.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

…ent does what.

Ensure that there is always a header-like title/position or organization displayed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Small size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant