E2E test: fix plot save issue #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonvanausdeln
approved these changes
Nov 22, 2024
midleman
approved these changes
Nov 22, 2024
| @@ -149,9 +149,14 @@ test.describe('Plots', () => { | |||
| await app.code.driver.getLocator('.positron-modal-dialog-box .file .positron-button.drop-down-list-box').click(); | |||
| await app.workbench.positronPopups.clickOnModalDialogPopupOption('JPEG'); | |||
|
|
|||
| // bug workaround | |||
| await app.code.wait(1000); | |||
There was a problem hiding this comment.
No one does :)
Feel free to try and find something to wait on. There is nothing that i see
There was a problem hiding this comment.
I might circle back after I update user settings fixes. 🙃
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python plot save was failing. Added a brief wait before clicking save and a wait for the dialog to disappear.
QA Notes
All smoke tests should pass.