Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-30230 : Create all px configmaps in same namespace as portworx #320

Open
wants to merge 5 commits into
base: porx
Choose a base branch
from

Conversation

nikita-bhatia
Copy link
Contributor

https://portworx.atlassian.net/browse/PWX-30230

This PR is for migration of namespace from 'kube-system' to 'portworx'. To support this,

Added coreConfigMap struct as wrapper function for existing configmap.
Added Instance() to decide which configmap to use, and handle upgrade scenarios
Logic to update copylock config map entry once upgrade is finished will be handled in porx code.
This PR is to cherrypick changes to 'porx' branch of sched-ops, to update vendor dependency in porx repo.

Signed-off-by: Nikita Bhatia <[email protected]>
Signed-off-by: Nikita Bhatia <[email protected]>
Signed-off-by: Nikita Bhatia <[email protected]>
Signed-off-by: Nikita Bhatia <[email protected]>
@nikita-bhatia nikita-bhatia changed the title Cherrypick ns PWX-30230 : Create all px configmaps in same namespace as portworx Jul 3, 2023
Copy link
Contributor

@nrevanna nrevanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to be similar to #314 except for configmap_test. Why do we have two PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants