build: bump k8s.io/client-go to v0.20.4 #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This excludes pulling k8s.io/client-go(v12.0.0+incompatible) which breaks integration with consumers of the https://github.com/libopenstorage/secrets library since it pulls https://github.com/portworx/sched-ops. Also, sched-ops recently moved to k8s 1.20 in portworx#238 so I'm not sure why this line was still around. Signed-off-by: Sébastien Han <[email protected]>
|
@harsh-px @disrani-px PTAL, thanks! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This excludes pulling k8s.io/client-go(v12.0.0+incompatible) which
breaks integration with consumers of the
https://github.com/libopenstorage/secrets library since it pulls
https://github.com/portworx/sched-ops.
Also, sched-ops recently moved to k8s 1.20 in
#238 so I'm not sure why this
line was still around.
Signed-off-by: Sébastien Han [email protected]
Special notes for your reviewer:
Thanks for considering this PR, if this is causing internal issues I have no control over then I can try to remove https://github.com/portworx/sched-ops as a dependency from https://github.com/libopenstorage/secrets since its usage is quite small.