PB-7977 : Deprecating delete_backups

- delete_backups deprecated from ClusterDeleteRequest - delete_backups deprecated from BackupLocationDeleteRequest Signed-off-by: Vikas Kumar <[email protected]>
portworx · Aug 30, 2024 · bab77d7 · bab77d7
1 parent 0258942
commit bab77d7
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -2,7 +2,7 @@
 # Do not use directly, use `make docker-build-proto` instead
 #
 
-FROM golang:1.20
+FROM golang:1.23
 ENV GOPATH=/go
 RUN mkdir -p portworx/px-backup-api
 WORKDIR portworx/px-backup-api

diff --git a/pkg/apis/v1/api.pb.go b/pkg/apis/v1/api.pb.go
diff --git a/pkg/apis/v1/api.proto b/pkg/apis/v1/api.proto
@@ -1295,6 +1295,7 @@ message ClusterDeleteRequest {
     string name = 2;
     // delete_backups indicates whether the backup related to cluster need to
     // be deleted or retained.
+    // delete_backups is deprecated, not to be used.
     bool delete_backups = 3;
     // delete_restores indicates whether the restore related to cluster  need to
     // be deleted or retained.
@@ -1815,6 +1816,7 @@ message BackupLocationDeleteRequest {
     string name = 2;
     // delete_backups indicates whether the cloud backup files need to
     // be deleted or retained.
+    // delete_backups is deprecated, not to be used.
     bool delete_backups = 3;
     string uid = 4;
 }

diff --git a/pkg/apis/v1/api.swagger.json b/pkg/apis/v1/api.swagger.json
@@ -538,7 +538,7 @@
           },
           {
             "name": "delete_backups",
-            "description": "delete_backups indicates whether the cloud backup files need to\nbe deleted or retained.",
+            "description": "delete_backups indicates whether the cloud backup files need to\nbe deleted or retained.\ndelete_backups is deprecated, not to be used.",
             "in": "query",
             "required": false,
             "type": "boolean",
@@ -1166,7 +1166,7 @@
           },
           {
             "name": "delete_backups",
-            "description": "delete_backups indicates whether the backup related to cluster need to\nbe deleted or retained.",
+            "description": "delete_backups indicates whether the backup related to cluster need to\nbe deleted or retained.\ndelete_backups is deprecated, not to be used.",
             "in": "query",
             "required": false,
             "type": "boolean",
@@ -3295,7 +3295,8 @@
         },
         "retention_time": {
           "type": "string",
-          "format": "date-time"
+          "format": "date-time",
+          "title": "this will store the timestamp, when the retention period of locked backup will be expired"
         }
       }
     },