-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nfs backup failure with latest changes for anyuid support #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbinnal-px
requested review from
lalat-das,
siva-portworx,
pallav-px and
vsundarraj-px
November 22, 2024 03:45
License Evaluation Results:
Total License Issues: 17 |
dbinnal-px
force-pushed
the
PB-8630-f
branch
from
November 22, 2024 03:51
84cf4e3
to
bddd4be
Compare
License Evaluation Results:
Total License Issues: 17 |
dbinnal-px
force-pushed
the
PB-8630-f
branch
from
November 22, 2024 07:15
bddd4be
to
3ccc2d8
Compare
License Evaluation Results:
Total License Issues: 17 |
dbinnal-px
force-pushed
the
PB-8630-f
branch
from
November 22, 2024 08:29
3ccc2d8
to
c068abd
Compare
License Evaluation Results:
Total License Issues: 17 |
dbinnal-px
force-pushed
the
PB-8630-f
branch
from
November 22, 2024 09:56
c068abd
to
550f9f0
Compare
License Evaluation Results:
Total License Issues: 17 |
lalat-das
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
NFS backup path is failing, as we are trying to fetch pvc based on pvc name to check if the anyuid annotation has to be se or not. And incase of NFS backup and restore JOB pods we are not passing pvc name in the job options as it is not required.
So, based on this we think we would not need to set roleDindingForSCC and anyuid annotation for NFS backup and NFS Restore.
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:
For Testing I set cephfs as a provisioner to use anyuid in kdmp-config