Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: use new debian, add data_url arg #246

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

stephank
Copy link
Member

Based on #240. Does this work for you @jimdigriz? I tried with and without data_url, and think it works as expected. Not sure if you had a specific need for the slim image variants?

Example output of docker image history:

IMAGE          CREATED             CREATED BY                                      SIZE      COMMENT
439b77868c37   About an hour ago   EXPOSE map[3333/tcp:{}]                         0B        buildkit.dockerfile.v0
<missing>      About an hour ago   ENV BROKER_LISTEN_IP=::                         0B        buildkit.dockerfile.v0
<missing>      About an hour ago   USER portier-broker                             0B        buildkit.dockerfile.v0
<missing>      About an hour ago   ENTRYPOINT ["/opt/portier-broker/portier-bro…   0B        buildkit.dockerfile.v0
<missing>      About an hour ago   WORKDIR /opt/portier-broker                     0B        buildkit.dockerfile.v0
<missing>      About an hour ago   COPY /data /opt/portier-broker # buildkit       14.5kB    buildkit.dockerfile.v0
<missing>      About an hour ago   COPY /build/target/release/portier-broker /o…   20.5MB    buildkit.dockerfile.v0
<missing>      About an hour ago   RUN /bin/sh -c set -x   && apt-get update   …   3.68MB    buildkit.dockerfile.v0
<missing>      About an hour ago   RUN /bin/sh -c set -x   && groupadd -r -g 99…   329kB     buildkit.dockerfile.v0
<missing>      8 days ago          /bin/sh -c #(nop)  CMD ["bash"]                 0B
<missing>      8 days ago          /bin/sh -c #(nop) ADD file:22ed184e421fcac77…   124MB

@jimdigriz
Copy link
Contributor

Looks okay for what I need. I will not have the time to try this till the start of June, so if you wanted to just go ahead and merge this then do not let me hold you up. Thanks

@stephank
Copy link
Member Author

stephank commented Jun 9, 2021

Alright, I'll merge this now. We can continue discussing in #240. Thanks! 🙂

@stephank stephank merged commit c97eacc into main Jun 9, 2021
@stephank stephank deleted the feat-upgrade-docker branch June 9, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants