-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial ory route #4612
initial ory route #4612
Conversation
f3e7ccd
to
01b724b
Compare
8391b28
to
c92dcf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of error states here - for testing, if you haven't already, i would recommend actually throwing new Error() objects in the code wherever appropriate and making sure that the error states / messaging makes sense
dashboard/src/main/MainWrapper.tsx
Outdated
{/* We dont need to pass any custom translations */} | ||
{/* <IntlProvider> */} | ||
{/* We pass custom translations */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
dashboard/src/shared/auth/sdk.ts
Outdated
export const sdk = new FrontendApi( | ||
new Configuration({ | ||
basePath, | ||
// we always want to include the cookies in each request | ||
// cookies are used for sessions and CSRF protection | ||
baseOptions: { | ||
withCredentials: true, | ||
}, | ||
}) | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason this defined twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed, thanks
No description provided.