Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial ory route #4612

Merged
merged 5 commits into from
May 8, 2024
Merged

initial ory route #4612

merged 5 commits into from
May 8, 2024

Conversation

d-g-town
Copy link
Collaborator

@d-g-town d-g-town commented May 6, 2024

No description provided.

@d-g-town d-g-town force-pushed the dgtown/ory-hidden-route branch 2 times, most recently from f3e7ccd to 01b724b Compare May 7, 2024 14:58
@d-g-town d-g-town force-pushed the dgtown/ory-hidden-route branch from 8391b28 to c92dcf1 Compare May 7, 2024 16:21
@d-g-town d-g-town changed the title wip add hidden ory route for porter users May 7, 2024
@d-g-town d-g-town changed the title add hidden ory route for porter users initial ory route May 7, 2024
Copy link

@ferozemohideen ferozemohideen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of error states here - for testing, if you haven't already, i would recommend actually throwing new Error() objects in the code wherever appropriate and making sure that the error states / messaging makes sense

Comment on lines 20 to 22
{/* We dont need to pass any custom translations */}
{/* <IntlProvider> */}
{/* We pass custom translations */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

dashboard/src/main/auth/OryLogin.tsx Outdated Show resolved Hide resolved
Comment on lines 10 to 20
export const sdk = new FrontendApi(
new Configuration({
basePath,
// we always want to include the cookies in each request
// cookies are used for sessions and CSRF protection
baseOptions: {
withCredentials: true,
},
})
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason this defined twice?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, thanks

@d-g-town d-g-town enabled auto-merge (squash) May 8, 2024 13:49
@d-g-town d-g-town merged commit b85ae47 into master May 8, 2024
9 checks passed
@d-g-town d-g-town deleted the dgtown/ory-hidden-route branch May 8, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants