Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POR-1440 use previews config as overrides in validate apply flow #3670

Merged
merged 4 commits into from
Sep 28, 2023
Merged

POR-1440 use previews config as overrides in validate apply flow #3670

merged 4 commits into from
Sep 28, 2023

Conversation

ianedwards
Copy link
Contributor

POR-1440

What does this PR do?

  • Run validate using parsed preview override values from porter.yaml when running CLI
  • Incorporate env variable overrides
  • Pass final app contract using overrides to apply when creating new revision

d-g-town
d-g-town reviewed Sep 28, 2023
View reviewed changes
cli/cmd/v2/apply.go Outdated Show resolved Hide resolved
@ianedwards ianedwards force-pushed the validate-apply-with-overrides branch from 072d4d5 to d026b1b Compare September 28, 2023 21:31
@ianedwards ianedwards merged commit 88ce84a into master Sep 28, 2023
9 checks passed
@ianedwards ianedwards deleted the validate-apply-with-overrides branch September 28, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-g-town d-g-town d-g-town approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianedwards @d-g-town