Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POR-1592 support branch specific deploys from cli #3634

Merged
merged 4 commits into from
Sep 25, 2023
Merged

POR-1592 support branch specific deploys from cli #3634

merged 4 commits into from
Sep 25, 2023

Conversation

ianedwards
Copy link
Contributor

@ianedwards ianedwards commented Sep 22, 2023 •
edited
Loading

POR-1592

What does this PR do?

  • Adds CLI support for preview environments from a given repo
  • Creates a new deployment target based on the name of the checked out branch with preview set to true; adding this bool as a new field to deployment targets because I imagine there will be many instances when we'll want to query for all preview environments in a given cluster
  • Removes scenarios where we fall back on the first deployment target as it will now be possible to have multiple
  • Creates a domain specific to the (app name, branch name) pair

d-g-town
d-g-town reviewed Sep 25, 2023
View reviewed changes
cli/cmd/v2/apply.go Outdated Show resolved Hide resolved
d-g-town
d-g-town reviewed Sep 25, 2023
View reviewed changes
cli/cmd/v2/apply.go Outdated Show resolved Hide resolved
d-g-town
d-g-town reviewed Sep 25, 2023
View reviewed changes
cli/cmd/v2/apply.go Outdated Show resolved Hide resolved
@ianedwards ianedwards enabled auto-merge (squash) September 25, 2023 19:08
@ianedwards ianedwards merged commit 7c54d20 into master Sep 25, 2023
8 checks passed
@ianedwards ianedwards deleted the preview-deploy-support-cli branch September 25, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-g-town d-g-town d-g-town approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianedwards @d-g-town