Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow private to be missing without using default of false #3616

Merged
merged 5 commits into from
Sep 20, 2023
Merged

allow private to be missing without using default of false #3616

merged 5 commits into from
Sep 20, 2023

Conversation

ianedwards
Copy link
Contributor

What does this PR do?

  • Allows for private to be an undefined value
  • If we do not accommodate for this, it will be parsed in as false when read from porter.yaml

@ianedwards ianedwards enabled auto-merge (squash) September 20, 2023 21:57
@ianedwards ianedwards merged commit 560a76a into master Sep 20, 2023
8 checks passed
@ianedwards ianedwards deleted the handle-missing-private-field branch September 20, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferozemohideen ferozemohideen ferozemohideen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianedwards @ferozemohideen