[POR-1673] Implement Job History in New View #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-g-town
reviewed
Sep 20, 2023
ianedwards
approved these changes
Sep 20, 2023
| ); | ||
|
|
||
| useEffect(() => { | ||
| if (data != null) { |
There was a problem hiding this comment.
I think this is going to be undefined by default
Comment on lines
2
to
5
| import { timeFrom } from "shared/string_utils"; | ||
|
|
||
| export const ranFor = (start: string, end?: string | number) => { | ||
| const duration = timeFrom(start, end); |
There was a problem hiding this comment.
Might make sense to do date processing like this on actual timestamps in the future instead of on strings
There was a problem hiding this comment.
Yeah we should swap this out with a library that does this in the future, I just copied this from existing
dashboard/src/main/home/app-dashboard/validate-apply/jobs/utils.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POR-1673
What does this PR do?
Screen.Recording.2023-09-20.at.3.18.40.PM.mov