feat: add telemetry for the cluster status endpoint #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jose-fully-ported
force-pushed
the
jose-fully-ported/status-telemetry
branch
from
55010ca to
62e95fd
Compare
ferozemohideen
suggested changes
Sep 20, 2023
| c.HandleAPIError(w, r, apierrors.NewErrInternal(e)) | ||
| err := fmt.Errorf("unable to retrieve status for cluster: %w", err) | ||
| err = telemetry.Error(ctx, span, err, err.Error()) | ||
| c.HandleAPIError(w, r, apierrors.NewErrInternal(err)) |
There was a problem hiding this comment.
Just didn't want to change the response here.
jose-fully-ported
force-pushed
the
jose-fully-ported/status-telemetry
branch
from
62e95fd to
dc73a84
Compare
ferozemohideen
approved these changes
Sep 20, 2023
jose-fully-ported
force-pushed
the
jose-fully-ported/status-telemetry
branch
from
dc73a84 to
269a704
Compare
Without this, internal service errors get swallowed up.
jose-fully-ported
force-pushed
the
jose-fully-ported/status-telemetry
branch
from
269a704 to
337f1da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds some telemetry to the cluster status endpoint. The endpoint currently just returns an internal service error without any extra context. Without this change, internal service errors get swallowed up, making debugging more difficult.