Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3rd party tools which require kubeconfig #3604

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

stefanmcshane
Copy link
Collaborator

@stefanmcshane stefanmcshane commented Sep 20, 2023

What does this PR do?

Support 3rd party tools which require a kubeconfig such as k9s.

  • Added porter kubectl --print-kubeconfig flag which prints a generated kubeconfig to the console, with 15 minutes expiry.
  • Added cobra.Command to all run functions, so we can start moving away from globally defined flags, allowing flag parsing within each individually run function

porter kubectl --print-kubeconfig | k9s --kubeconfig /dev/stdin would pipe the kubeconfig directly to k9s for example

@gitguardian
Copy link

gitguardian bot commented Sep 20, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@stefanmcshane
Copy link
Collaborator Author

Secret was a temporary certificate that was used during testing on a local cluster, and no longer exists. False positive

@stefanmcshane stefanmcshane enabled auto-merge (squash) September 20, 2023 05:20
@stefanmcshane stefanmcshane merged commit 65b181f into master Sep 26, 2023
8 checks passed
@stefanmcshane stefanmcshane deleted the sms/k9s-support branch September 26, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants