Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default builders to be Ubuntu 22.04 based #3602

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Set default builders to be Ubuntu 22.04 based #3602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0398caa
feat: add ubuntu 22.04 as supported builders for both packeto and heroku
jose-fully-ported Sep 19, 2023
7e63aac
feat: set default heroku/packeto builders to ubuntu 22.04
jose-fully-ported Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/server/handlers/gitinstallation/get_buildpack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@ func initBuilderInfo() map[string]*buildpacks.BuilderInfo {
builders[buildpacks.PaketoBuilder] = &buildpacks.BuilderInfo{
Name: "Paketo",
Builders: []string{
"paketobuildpacks/builder-jammy-full:latest",
"paketobuildpacks/builder:full",
},
}
builders[buildpacks.HerokuBuilder] = &buildpacks.BuilderInfo{
Name: "Heroku",
Builders: []string{
"heroku/buildpacks:22",
"heroku/buildpacks:20",
"heroku/buildpacks:18",
},
Expand Down
2 changes: 2 additions & 0 deletions api/server/handlers/project_integration/get_gitlab_repo_buildpack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,14 @@ func initBuilderInfo() map[string]*buildpacks.BuilderInfo {
builders[buildpacks.PaketoBuilder] = &buildpacks.BuilderInfo{
Name: "Paketo",
Builders: []string{
"paketobuildpacks/builder-jammy-full:latest",
"paketobuildpacks/builder:full",
},
}
builders[buildpacks.HerokuBuilder] = &buildpacks.BuilderInfo{
Name: "Heroku",
Builders: []string{
"heroku/buildpacks:22",
"heroku/buildpacks:20",
"heroku/buildpacks:18",
},
Expand Down
4 changes: 2 additions & 2 deletions dashboard/src/components/repo-selector/BuildpackSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import { ActionConfigType } from "shared/types";
import styled, { keyframes } from "styled-components";

const DEFAULT_BUILDER_NAME = "heroku";
const DEFAULT_PAKETO_STACK = "paketobuildpacks/builder:full";
const DEFAULT_HEROKU_STACK = "heroku/buildpacks:20";
const DEFAULT_PAKETO_STACK = "paketobuildpacks/builder-jammy-full:latest";
const DEFAULT_HEROKU_STACK = "heroku/buildpacks:22";

type BuildConfig = {
builder: string;
Expand Down
4 changes: 2 additions & 2 deletions dashboard/src/main/home/app-dashboard/types/buildpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export const detectedBuildpackSchema = z.object({
export type DetectedBuildpack = z.infer<typeof detectedBuildpackSchema>;

export const DEFAULT_BUILDER_NAME = "heroku";
export const DEFAULT_PAKETO_STACK = "paketobuildpacks/builder:full";
export const DEFAULT_HEROKU_STACK = "heroku/buildpacks:20";
export const DEFAULT_PAKETO_STACK = "paketobuildpacks/builder-jammy-full:latest";
export const DEFAULT_HEROKU_STACK = "heroku/buildpacks:22";

export const BUILDPACK_TO_NAME: { [key: string]: string } = {
"heroku/nodejs": "NodeJS",
Expand Down