POR-1756: add telemetry to pr creation endpoint #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozemohideen
suggested changes
Sep 19, 2023
Comment on lines
+92
to
+94
| err = fmt.Errorf("error generating secret: %w", err) | ||
| err := telemetry.Error(ctx, span, err, err.Error()) | ||
| c.HandleAPIError(w, r, apierrors.NewErrInternal(err)) |
There was a problem hiding this comment.
same thing here, also prefer passing all error messages to client and obfuscating if necessary on client-side
There was a problem hiding this comment.
same as above.
ferozemohideen
approved these changes
Sep 19, 2023
At the moment, this endpoint doesn't show any metrics in honeycomb, making it difficult to debug. Refs POR-1756
jose-fully-ported
force-pushed
the
jose-fully-ported/telemetry-for-prs
branch
from
0b96763 to
7041cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm submitting calls to the api to create a PR for a repo and getting errors. At the moment, this endpoint doesn't show any metrics in honeycomb, making it difficult to debug. This PR adds some telemetry so we can see where exactly things are failing.