disable msg nit and fix rendering bug (#3687)

porter-dev · Sep 29, 2023 · d0ab2a5 · d0ab2a5
1 parent 3c208e0
commit d0ab2a5
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/dashboard/src/main/home/app-dashboard/app-view/AppDataContainer.tsx b/dashboard/src/main/home/app-dashboard/app-view/AppDataContainer.tsx
@@ -314,6 +314,7 @@ const AppDataContainer: React.FC<AppDataContainerProps> = ({ tabParam }) => {
     });
   }, [
     servicesFromYaml,
+    currentTab,
     latestProto,
     previewRevision,
     latestRevision.revision_number,
@@ -347,7 +348,7 @@ const AppDataContainer: React.FC<AppDataContainerProps> = ({ tabParam }) => {
                     latestRevision.status === "CREATED" ||
                     latestRevision.status === "AWAITING_BUILD_ARTIFACT"
                   }
-                  disabledTooltipMessage="Please wait for the build to complete before updating the app"
+                  disabledTooltipMessage="Please wait for the deploy to complete before updating the app"
                 >
                   <Icon src={save} height={"13px"} />
                   <Spacer inline x={0.5} />

diff --git a/dashboard/src/main/home/app-dashboard/app-view/tabs/Environment.tsx b/dashboard/src/main/home/app-dashboard/app-view/tabs/Environment.tsx
@@ -87,7 +87,7 @@ const Environment: React.FC<Props> = ({ latestSource }) => {
           latestRevision.status === "CREATED" ||
           latestRevision.status === "AWAITING_BUILD_ARTIFACT"
         }
-        disabledTooltipMessage="Please wait for the build to complete before updating environment variables"
+        disabledTooltipMessage="Please wait for the deploy to complete before updating environment variables"
       >
         Update app
       </Button>

diff --git a/dashboard/src/main/home/app-dashboard/app-view/tabs/Overview.tsx b/dashboard/src/main/home/app-dashboard/app-view/tabs/Overview.tsx
@@ -84,7 +84,7 @@ const Overview: React.FC = () => {
           latestRevision.status === "CREATED" ||
           latestRevision.status === "AWAITING_BUILD_ARTIFACT"
         }
-        disabledTooltipMessage="Please wait for the build to complete before updating services"
+        disabledTooltipMessage="Please wait for the deploy to complete before updating services"
       >
         Update app
       </Button>

diff --git a/dashboard/src/main/home/app-dashboard/validate-apply/services-settings/tabs/Resources.tsx b/dashboard/src/main/home/app-dashboard/validate-apply/services-settings/tabs/Resources.tsx
@@ -34,7 +34,11 @@ const Resources: React.FC<ResourcesProps> = ({
     <>
       <Spacer y={1} />
       <Controller
-        name={isPredeploy ? `app.predeploy.${index}.cpuCores` : `app.services.${index}.cpuCores`}
+        name={
+          isPredeploy
+            ? `app.predeploy.${index}.cpuCores`
+            : `app.services.${index}.cpuCores`
+        }
         control={control}
         render={({ field: { value, onChange } }) => (
           <InputSlider
@@ -60,7 +64,11 @@ const Resources: React.FC<ResourcesProps> = ({
       />
       <Spacer y={1} />
       <Controller
-        name={isPredeploy ? `app.predeploy.${index}.ramMegabytes` : `app.services.${index}.ramMegabytes`}
+        name={
+          isPredeploy
+            ? `app.predeploy.${index}.ramMegabytes`
+            : `app.services.${index}.ramMegabytes`
+        }
         control={control}
         render={({ field: { value, onChange } }) => (
           <InputSlider