feat: add support for buildpack urns (#3689)

porter-dev · Sep 29, 2023 · 3dfa522 · 3dfa522
1 parent 4c345eb
commit 3dfa522
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/...ard/src/main/home/app-dashboard/build-settings/buildpacks/AddCustomBuildpackComponent.tsx b/...ard/src/main/home/app-dashboard/build-settings/buildpacks/AddCustomBuildpackComponent.tsx
@@ -3,7 +3,12 @@ import React, { useState } from "react";
 import styled, { keyframes } from "styled-components";
 import { Buildpack } from "../../types/buildpack";
 
-function isValidURL(url: string): boolean {
+function isValidBuildpack(url: string): boolean {
+  const urnPrefix = "urn:cnb:registry:";
+  if (url.startsWith(urnPrefix)) {
+    return true;
+  }
+
   const pattern = /^(https?:\/\/)?([\w.-]+)\.([a-z]{2,})(:\d{2,5})?([\/\w.-]*)*\/?$/i;
   return pattern.test(url);
 }
@@ -15,7 +20,7 @@ const AddCustomBuildpackComponent: React.FC<{
   const [error, setError] = useState(false);
 
   const handleAddCustomBuildpack = () => {
-    if (buildpackUrl === "" || !isValidURL(buildpackUrl)) {
+    if (buildpackUrl === "" || !isValidBuildpack(buildpackUrl)) {
       setError(true);
       return;
     }

diff --git a/...c/main/home/app-dashboard/validate-apply/build-settings/buildpacks/AddCustomBuildpack.tsx b/...c/main/home/app-dashboard/validate-apply/build-settings/buildpacks/AddCustomBuildpack.tsx
@@ -3,7 +3,12 @@ import { Buildpack } from "main/home/app-dashboard/types/buildpack";
 import React, { useState } from "react";
 import styled, { keyframes } from "styled-components";
 
-function isValidURL(url: string): boolean {
+function isValidBuildpack(url: string): boolean {
+  const urnPrefix = "urn:cnb:registry:";
+  if (url.startsWith(urnPrefix)) {
+    return true;
+  }
+
   const pattern = /^(https?:\/\/)?([\w.-]+)\.([a-z]{2,})(:\d{2,5})?([\/\w.-]*)*\/?$/i;
   return pattern.test(url);
 }
@@ -15,7 +20,7 @@ const AddCustomBuildpack: React.FC<{
   const [error, setError] = useState(false);
 
   const handleAddCustomBuildpack = () => {
-    if (buildpackUrl === "" || !isValidURL(buildpackUrl)) {
+    if (buildpackUrl === "" || !isValidBuildpack(buildpackUrl)) {
       setError(true);
       return;
     }