feat(editor): add store prop #214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vercel
bot
temporarily deployed
to
Preview – editor-react-compiler
| this.change$.next({type: 'loading', isLoading: true}) | ||
|
|
||
| this.schemaTypes = getPortableTextMemberSchemaTypes( | ||
| props.schemaType.hasOwnProperty('jsonType') | ||
| ? props.schemaType | ||
| : compileType(props.schemaType), | ||
| ) | ||
|
|
||
| // If no store is provided then we just create one | ||
| this.store = props.store ?? createEditorStore() |
There was a problem hiding this comment.
The word store here is the only thing I can think could be discussed. I prefer the API – I just don't know about the terminology.
There was a problem hiding this comment.
Thanks! I've renamed it to editor now.
It's been deprecated for years. Time to remove it now that `patches$` is getting deprecated as well.
The `store` is a new, experimental way of interacting with and listening to events from the editor. So far it's only used to send patches into the editor.
christianhg
force-pushed
the
feat-pte-store
branch
from
5d0007a
to
6518f10
Compare
vercel
bot
temporarily deployed
to
Preview – editor-react-compiler
vercel
bot
temporarily deployed
to
Preview – editor-react-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
storeis a new, experimental way of interacting with and listening toevents from the editor.
So far it's only used to send patches into the editor.