-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PagerDuty created_at title to Created At #822
Conversation
Heya @JaanJah ! First of all, thanks for your time and contribution, much appreciated! The way do changelog is In addition, be sure to be up to date with the Besides that, the PR looks great! |
275bf50
to
eec00a7
Compare
Hi @erikzaadi, thanks for feedback, rebased my branch with upstream, actually having trouble with getting In integration directory I get:
and when I do
I tried to add the changelog entry manually for now, hopefully you can guide me to make it correct. Also feedback for the future, the |
@JaanJah ty for the feedback, duly noted! We'll make sure it's clearer. Cheers! |
eec00a7
to
376635f
Compare
@erikzaadi Bumped CHANGELOG version and rebased. |
Running CI |
@JaanJah one thing that I forgot, do bump the pyproject.toml's version as well |
376635f
to
a238050
Compare
@erikzaadi, I updated |
fa26606
to
4717123
Compare
Thanks! |
Description
What - Change
created_at
property title fromCreate At
toCreated At
in PagerDutyblueprints.json
Why - Makes more sense
How - Changing the
blueprints.json
Fixes #821
Type of change
Please leave one option from the following and delete the rest:
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation