Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PagerDuty created_at title to Created At #822

Closed
wants to merge 2 commits into from

Conversation

JaanJah
Copy link
Contributor

@JaanJah JaanJah commented Jul 16, 2024

Description

What - Change created_at property title from Create At to Created At in PagerDuty blueprints.json
Why - Makes more sense
How - Changing the blueprints.json

Fixes #821

Type of change

Please leave one option from the following and delete the rest:

  • Non-breaking change (fix of existing functionality that will not change current behavior)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

@erikzaadi
Copy link
Member

erikzaadi commented Jul 18, 2024

Heya @JaanJah !

First of all, thanks for your time and contribution, much appreciated!

The way do changelog is towncrier (which you ran), however, we don't commit the changelog file, instead we run towncrier build --yes --version ${NEW_VERSION} which updates the CHANGELOG.md.

In addition, be sure to be up to date with the main branch.

Besides that, the PR looks great!

@JaanJah
Copy link
Contributor Author

JaanJah commented Jul 23, 2024

Hi @erikzaadi, thanks for feedback, rebased my branch with upstream, actually having trouble with getting towncrier build command running, it's supposed to be ran in the root directory right or integration directory?

In integration directory I get:

ModuleNotFoundError: No module named 'port_ocean'

and when I do poetry add port_ocean[cli] then I get errors with pyjq dependency:

 _pyjq.c:7693:47: error: no member named 'ob_digit' in 'struct _longobject'
      const digit* digits = ((PyLongObject*)b)->ob_digit;
                            ~~~~~~~~~~~~~~~~~~  ^
  7 warnings and 8 errors generated.
  error: command '/usr/bin/clang' failed with exit code 1

I tried to add the changelog entry manually for now, hopefully you can guide me to make it correct.

Also feedback for the future, the towncrier build command seems to be missing from CONTRIBUTING.md document.

@erikzaadi
Copy link
Member

@JaanJah ty for the feedback, duly noted! We'll make sure it's clearer.
If you could rebase once more, then I can approve the CI flow to make sure all is ok.

Cheers!

@JaanJah
Copy link
Contributor Author

JaanJah commented Jul 25, 2024

@erikzaadi Bumped CHANGELOG version and rebased.

@erikzaadi
Copy link
Member

Running CI

@erikzaadi
Copy link
Member

@JaanJah one thing that I forgot, do bump the pyproject.toml's version as well

@JaanJah
Copy link
Contributor Author

JaanJah commented Jul 25, 2024

@erikzaadi, I updated pyproject.toml now.

@erikzaadi
Copy link
Member

@JaanJah thank you so much for your contribution!
I merged this here to save you the trouble of rebasing again, closing this one.

@erikzaadi erikzaadi closed this Aug 15, 2024
@JaanJah
Copy link
Contributor Author

JaanJah commented Aug 19, 2024

Thanks!

@JaanJah JaanJah deleted the pagerduty-create-at branch August 19, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] [Integration] [PagerDuty] Rename "Create At" property to "Created At"
3 participants