Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spin button behavior in desktop->appearance->mod.rs #783

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

bhh32
Copy link
Contributor

@bhh32 bhh32 commented Nov 21, 2024

Changes

Fixed the behavior of the spin button for the appearance settings.

Changed the order of the active hint spin button to the following:

cosmic::widget::spin_button(
    page.theme_builder.active_hint.to_string(),
    page.theme_builder.active_hint,
    1,
    0,
    500,
    Message::WindowHintSize,
),

It was changed from:

cosmic::widget::spin_button(
    page.theme_builder.active_hint.to_string(),
    1,
    page.theme.active_hint,
    0,
    500,
    Message::WindowHintSize,
),

Reason for the Change

The reason for the change is because the the step and value were swapped making both the active_hint spin button and the gaps spin button have unintended behaviors.

@mmstick mmstick merged commit 4e31002 into pop-os:master Nov 21, 2024
3 checks passed
@mmstick
Copy link
Member

mmstick commented Nov 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants