Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi gpu applet support (app-list/battery) #206

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Jan 24, 2024

Test together with pop-os/cosmic-comp#278

Updates cosmic-app-list context menu and adds a gpu indicator and process list to the battery applet.

Missing features:

  • Use cosmic-toplevel-info to get window list, enumerate .desktop files, and match executable names deferred until we get PIDs from cosmic-comp
  • Filter out cosmic-comp from the process list
  • Check connectors with libdrm and list external monitors keeping GPU active
  • Try to group processes (libproc could likely be used to get a proper tree and match process ids) deferred until we have PIDs
  • Reading the GPU name via udev doesn't work fixed
  • Hotplugging code is untested not super important, only concerns thunderbolt gpus
  • lsof path for Radeon/Intel dGPUs is untested - does somebody have a laptop with a dedicated amd gpu / intel xe gpu? done

@Drakulix Drakulix changed the title battery: Add gpu indicator and process list Add multi gpu applet support (app-list/battery) Feb 1, 2024
@Drakulix Drakulix marked this pull request as ready for review February 1, 2024 18:55
@Drakulix Drakulix requested a review from wash2 February 6, 2024 17:31
@Drakulix Drakulix merged commit c71420c into master Feb 6, 2024
5 of 7 checks passed
@Drakulix Drakulix deleted the hybridgpu_jammy branch February 6, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants