Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launch settings with activation token #157

Merged
merged 6 commits into from
Nov 22, 2023
Merged

launch settings with activation token #157

merged 6 commits into from
Nov 22, 2023

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Nov 17, 2023

No description provided.

@wash2 wash2 force-pushed the activate-settings_jammy branch 2 times, most recently from 1f9c63e to 7a5f393 Compare November 17, 2023 17:35
@wash2 wash2 changed the title wip(time): launch settings with activation token launch settings with activation token Nov 22, 2023
@wash2 wash2 marked this pull request as ready for review November 22, 2023 00:25
@wash2 wash2 requested a review from a team November 22, 2023 00:26
Drakulix
Drakulix approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But why do we even pass exec to the TokenRequest, if we never use it on the ActivationToken message? 😅

@wash2
Copy link
Contributor Author

wash2 commented Nov 22, 2023

But why do we even pass exec to the TokenRequest, if we never use it on the ActivationToken message?

Fair, I guess I just thought maybe it could be useful later so I kept it 😅

@wash2 wash2 merged commit b7b7b95 into master_jammy Nov 22, 2023
8 checks passed
@wash2 wash2 deleted the activate-settings_jammy branch November 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wash2 @Drakulix