fix: update shlex #111
wash2Annotations
10 warnings
|
field `icon` is never read:
cosmic-panel-button/src/main.rs#L9
warning: field `icon` is never read
--> cosmic-panel-button/src/main.rs:9:5
|
7 | struct Desktop {
| ------- field in this struct
8 | name: String,
9 | icon: Option<String>,
| ^^^^
|
= note: `Desktop` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L168
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:168:81
|
168 | let media_players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn)
| ^^^^^ help: change this to: `conn`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L227
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:227:87
|
227 | let players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn)
| ^^^^^ help: change this to: `conn`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
cosmic-applet-audio/src/mpris_subscription.rs#L253
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> cosmic-applet-audio/src/mpris_subscription.rs:253:15
|
253 | a.cmp(&b)
| ^^ help: change this to: `b`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
very complex type used. Consider factoring parts into `type` definitions:
cosmic-applet-audio/src/pulse.rs#L22
warning: very complex type used. Consider factoring parts into `type` definitions
--> cosmic-applet-audio/src/pulse.rs:22:24
|
22 | pub static FROM_PULSE: Lazy<Mutex<Option<(mpsc::Receiver<Message>, mpsc::Sender<Message>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
this function has too many arguments (9/7):
cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7)
--> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1
|
24 | // #[dbus_proxy(
25 | || interface = "org.freedesktop.Notifications",
26 | || default_service = "org.freedesktop.Notifications",
27 | || default_path = "/org/freedesktop/Notifications"
28 | || )]
| ||__- in this procedural macro expansion
... |
49 | | expire_timeout: i32,
50 | | ) -> zbus::Result<u32>;
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
= note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this function has too many arguments (9/7):
cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7)
--> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1
|
24 | / #[dbus_proxy(
25 | | interface = "org.freedesktop.Notifications",
26 | | default_service = "org.freedesktop.Notifications",
27 | | default_path = "/org/freedesktop/Notifications"
28 | | )]
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
useless conversion to the same type: `&str`:
cosmic-applet-notifications/src/main.rs#L164
warning: useless conversion to the same type: `&str`
--> cosmic-applet-notifications/src/main.rs:164:31
|
164 | .watch_config(cosmic_notifications_config::ID.into())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cosmic_notifications_config::ID`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
non-binding `let` on a future:
cosmic-applet-audio/src/main.rs#L455
warning: non-binding `let` on a future
--> cosmic-applet-audio/src/main.rs:455:25
|
455 | / _ = tokio::spawn(async move {
456 | | tokio::time::sleep(tokio::time::Duration::from_secs(30)).await;
457 | | conn.send(pulse::Message::UpdateConnection);
458 | | });
| |__________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|
|
useless conversion to the same type: `&str`:
cosmic-applet-audio/src/main.rs#L563
warning: useless conversion to the same type: `&str`
--> cosmic-applet-audio/src/main.rs:563:36
|
563 | self.core.watch_config(Self::APP_ID.into()).map(|u| {
| ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Self::APP_ID`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|