Skip to content

Multiple fixes jammy #106

Multiple fixes jammy

Multiple fixes jammy #106

Triggered via pull request January 19, 2024 03:13
Status Success
Total duration 2m 37s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
methods `get_sender` and `workspaces` are never used: cosmic-applet-workspaces/src/wayland_subscription.rs#L83
warning: methods `get_sender` and `workspaces` are never used --> cosmic-applet-workspaces/src/wayland_subscription.rs:83:12 | 76 | impl WorkspacesWatcher { | ---------------------- methods in this implementation ... 83 | pub fn get_sender(&self) -> SyncSender<WorkspaceEvent> { | ^^^^^^^^^^ ... 87 | pub async fn workspaces(&mut self) -> Option<WorkspaceList> { | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
variants `SetPairable` and `SetDiscoverable` are never constructed: cosmic-applet-bluetooth/src/bluetooth.rs#L121
warning: variants `SetPairable` and `SetDiscoverable` are never constructed --> cosmic-applet-bluetooth/src/bluetooth.rs:121:5 | 119 | pub enum BluerRequest { | ------------ variants in this enum 120 | SetBluetoothEnabled(bool), 121 | SetPairable(bool), | ^^^^^^^^^^^ 122 | SetDiscoverable(bool), | ^^^^^^^^^^^^^^^ | = note: `BluerRequest` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
non-canonical implementation of `partial_cmp` on an `Ord` type: cosmic-applet-bluetooth/src/bluetooth.rs#L188
warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> cosmic-applet-bluetooth/src/bluetooth.rs:188:1 | 188 | / impl PartialOrd for BluerDevice { 189 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> { | | _______________________________________________________________________- 190 | || match self.status.cmp(&other.status) { 191 | || std::cmp::Ordering::Equal => { 192 | || Some(self.name.to_lowercase().cmp(&other.name.to_lowercase())) ... || 195 | || } 196 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 197 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
this function has too many arguments (9/7): cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7) --> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1 | 24 | // #[dbus_proxy( 25 | || interface = "org.freedesktop.Notifications", 26 | || default_service = "org.freedesktop.Notifications", 27 | || default_path = "/org/freedesktop/Notifications" 28 | || )] | ||__- in this procedural macro expansion ... | 49 | | expire_timeout: i32, 50 | | ) -> zbus::Result<u32>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default = note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
this function has too many arguments (9/7): cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs#L24
warning: this function has too many arguments (9/7) --> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1 | 24 | / #[dbus_proxy( 25 | | interface = "org.freedesktop.Notifications", 26 | | default_service = "org.freedesktop.Notifications", 27 | | default_path = "/org/freedesktop/Notifications" 28 | | )] | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: this warning originates in the attribute macro `dbus_proxy` (in Nightly builds, run with -Z macro-backtrace for more info)
useless conversion to the same type: `&str`: cosmic-applet-notifications/src/main.rs#L164
warning: useless conversion to the same type: `&str` --> cosmic-applet-notifications/src/main.rs:164:31 | 164 | .watch_config(cosmic_notifications_config::ID.into()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cosmic_notifications_config::ID` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: cosmic-applet-audio/src/mpris_subscription.rs#L168
warning: this expression creates a reference which is immediately dereferenced by the compiler --> cosmic-applet-audio/src/mpris_subscription.rs:168:81 | 168 | let media_players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn) | ^^^^^ help: change this to: `conn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: cosmic-applet-audio/src/mpris_subscription.rs#L227
warning: this expression creates a reference which is immediately dereferenced by the compiler --> cosmic-applet-audio/src/mpris_subscription.rs:227:87 | 227 | let players = mpris2_zbus::media_player::MediaPlayer::new_all(&conn) | ^^^^^ help: change this to: `conn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: cosmic-applet-audio/src/mpris_subscription.rs#L253
warning: this expression creates a reference which is immediately dereferenced by the compiler --> cosmic-applet-audio/src/mpris_subscription.rs:253:15 | 253 | a.cmp(&b) | ^^ help: change this to: `b` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
very complex type used. Consider factoring parts into `type` definitions: cosmic-applet-audio/src/pulse.rs#L22
warning: very complex type used. Consider factoring parts into `type` definitions --> cosmic-applet-audio/src/pulse.rs:22:24 | 22 | pub static FROM_PULSE: Lazy<Mutex<Option<(mpsc::Receiver<Message>, mpsc::Sender<Message>)>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default