Skip to content

Commit

Permalink
Add additional test environments
Browse files Browse the repository at this point in the history
Prior to this commit, we were only testing against a single SSL library
on Linux plus also a version on Windows.

We have seen that with http related code, we can encounter errors on
different SSL versions. See ponylang/net_ssl#105.
To adjust to this, with this test, we are adding testing against all our
main supported SSL versions on Linux.

This does not change our MacOS (not currently done) or our Windows testing
matrix for ponylang/http.
  • Loading branch information
SeanTAllen committed Jan 14, 2024
1 parent 314c3f3 commit 5c6dde8
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 5 deletions.
46 changes: 44 additions & 2 deletions .github/workflows/breakage-against-linux-ponyc-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:
types: [shared-docker-linux-builders-updated]

jobs:
vs-ponyc-latest:
name: Test against ponyc main
libressl-3-vs-ponyc-latest:
name: LibreSSL 3.x with most recent ponyc latest
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/shared-docker-ci-x86-64-unknown-linux-builder-with-libressl-3.7.3:latest
Expand All @@ -25,3 +25,45 @@ jobs:
type: stream
topic: ${{ github.repository }} scheduled job failure
content: ${{ github.server_url}}/${{ github.repository }}/actions/runs/${{ github.run_id }} failed.

openssl-1-vs-ponyc-release:
name: OpenSSL 1.x with most recent ponyc latest
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/shared-docker-ci-x86-64-unknown-linux-builder-with-openssl_1.1.1w:latest
steps:
- uses: actions/checkout@v3
- name: Test
run: make test config=debug ssl=1.1.x
- name: Send alert on failure
if: ${{ failure() }}
uses: zulip/github-actions-zulip/send-message@b62d5a0e48a4d984ea4fce5dd65ba691963d4db4
with:
api-key: ${{ secrets.ZULIP_SCHEDULED_JOB_FAILURE_API_KEY }}
email: ${{ secrets.ZULIP_SCHEDULED_JOB_FAILURE_EMAIL }}
organization-url: 'https://ponylang.zulipchat.com/'
to: notifications
type: stream
topic: ${{ github.repository }} scheduled job failure
content: ${{ github.server_url}}/${{ github.repository }}/actions/runs/${{ github.run_id }} failed.

openssl-3-vs-ponyc-release:
name: OpenSSL 3.x with most recent ponyc latest
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/shared-docker-ci-x86-64-unknown-linux-builder-with-openssl_3.1.3:latest
steps:
- uses: actions/checkout@v3
- name: Test
run: make test config=debug ssl=3.0.x
- name: Send alert on failure
if: ${{ failure() }}
uses: zulip/github-actions-zulip/send-message@b62d5a0e48a4d984ea4fce5dd65ba691963d4db4
with:
api-key: ${{ secrets.ZULIP_SCHEDULED_JOB_FAILURE_API_KEY }}
email: ${{ secrets.ZULIP_SCHEDULED_JOB_FAILURE_EMAIL }}
organization-url: 'https://ponylang.zulipchat.com/'
to: notifications
type: stream
topic: ${{ github.repository }} scheduled job failure
content: ${{ github.server_url}}/${{ github.repository }}/actions/runs/${{ github.run_id }} failed.
26 changes: 23 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,35 @@ jobs:
- name: Verify CHANGELOG
run: changelog-tool verify

vs-ponyc-release:
name: Test against recent ponyc release
libressl-3-vs-ponyc-release:
name: LibreSSL 3.x with most recent ponyc release
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/shared-docker-ci-x86-64-unknown-linux-builder-with-libressl-3.7.3:release
steps:
- uses: actions/checkout@v3
- name: Test
run: make test ssl=0.9.0 config=debug
run: make test config=debug ssl=0.9.0

openssl-1-vs-ponyc-release:
name: OpenSSL 1.x with most recent ponyc release
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/shared-docker-ci-x86-64-unknown-linux-builder-with-openssl_1.1.1w:release
steps:
- uses: actions/checkout@v3
- name: Test
run: make test config=debug ssl=1.1.x

openssl-3-vs-ponyc-release:
name: OpenSSL 3.x with most recent ponyc release
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/shared-docker-ci-x86-64-unknown-linux-builder-with-openssl_3.1.3:release
steps:
- uses: actions/checkout@v3
- name: Test
run: make test config=debug ssl=3.0.x

windows-vs-ponyc-release:
name: Test against recent ponyc release on Windows
Expand Down

0 comments on commit 5c6dde8

Please sign in to comment.