Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various bug fixes #17

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Various bug fixes #17

merged 6 commits into from
Sep 20, 2024

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Aug 28, 2024

  • Handle case where timestamp is null in asTimestamp
  • Handle calendar being null
  • Compare column names case-insensitive as documented here
  • Convert DECIMAL values to longs
  • Improve exception messages
  • Turn executeBatch/executeLargeBatch into a nop when the batch is empty

vogti
vogti approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens, for this PR!

@vogti vogti merged commit be78b21 into master Sep 20, 2024
32 checks passed
@vogti vogti deleted the standard-fixes branch September 20, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogti vogti vogti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gartens @vogti