Fix a few easy warnings

polypheny · Sep 28, 2023 · 2dc80ee · 2dc80ee
1 parent ef4c0b9
commit 2dc80ee
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 13 deletions.
diff --git a/src/main/java/org/polypheny/jdbc/meta/PolyphenyParameterMeta.java b/src/main/java/org/polypheny/jdbc/meta/PolyphenyParameterMeta.java
@@ -9,7 +9,7 @@ public class PolyphenyParameterMeta {
     /* As all values are unsigned in polypheny we hardcoded this. */
     private static final boolean SIGNEDNESS = false;
     private static final int PARAMETER_MODE = ParameterMetaData.parameterModeIn;
-    private static final int NULLABLITY = ParameterMetaData.parameterNullableUnknown;
+    private static final int NULLABILITY = ParameterMetaData.parameterNullableUnknown;
 
     @Getter
     private String parameterClassName;
@@ -36,7 +36,7 @@ public PolyphenyParameterMeta( ParameterMeta parameterMeta ) {
         this.parameterTypeName = parameterMeta.getTypeName();
         this.precision = parameterMeta.getPrecision();
         this.scale = parameterMeta.getScale();
-        this.isNullable = NULLABLITY;
+        this.isNullable = NULLABILITY;
         this.isSigned = SIGNEDNESS;
 
     }

diff --git a/src/main/java/org/polypheny/jdbc/multimodel/RelationalResult.java b/src/main/java/org/polypheny/jdbc/multimodel/RelationalResult.java
@@ -23,7 +23,6 @@
 import org.polypheny.jdbc.ProtoInterfaceClient;
 import org.polypheny.jdbc.ProtoInterfaceErrors;
 import org.polypheny.jdbc.ProtoInterfaceServiceException;
-import org.polypheny.jdbc.nativetypes.document.PolyDocument;
 import org.polypheny.jdbc.properties.PropertyUtils;
 import org.polypheny.db.protointerface.proto.Frame;
 import org.polypheny.db.protointerface.proto.Frame.ResultCase;

diff --git a/src/main/java/org/polypheny/jdbc/nativetypes/PolyList.java b/src/main/java/org/polypheny/jdbc/nativetypes/PolyList.java
@@ -21,7 +21,6 @@
 import java.util.Collection;
 import java.util.List;
 import lombok.EqualsAndHashCode;
-import lombok.Getter;
 import lombok.Value;
 import lombok.experimental.Delegate;
 import org.jetbrains.annotations.NotNull;

diff --git a/src/main/java/org/polypheny/jdbc/nativetypes/PolyString.java b/src/main/java/org/polypheny/jdbc/nativetypes/PolyString.java
@@ -25,8 +25,6 @@
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.polypheny.jdbc.ProtoInterfaceServiceException;
-import org.polypheny.db.protointerface.proto.ProtoString;
-import org.polypheny.db.protointerface.proto.ProtoValue;
 import org.polypheny.db.protointerface.proto.ProtoValue.ProtoValueType;
 
 public class PolyString extends PolyValue{

diff --git a/src/main/java/org/polypheny/jdbc/nativetypes/relational/PolyMap.java b/src/main/java/org/polypheny/jdbc/nativetypes/relational/PolyMap.java
@@ -52,7 +52,7 @@ public int compareTo( @NotNull PolyValue o ) {
         if ( !isSameType( o ) ) {
             return -1;
         }
-        Map<PolyValue, PolyValue> other = null;
+        Map<PolyValue, PolyValue> other;
         try {
             other = o.asMap();
         } catch ( ProtoInterfaceServiceException e ) {

diff --git a/src/main/java/org/polypheny/jdbc/properties/PropertyUtils.java b/src/main/java/org/polypheny/jdbc/properties/PropertyUtils.java
@@ -13,7 +13,6 @@
 import lombok.Getter;
 import org.polypheny.jdbc.ProtoInterfaceServiceException;
 import org.polypheny.jdbc.ProtoInterfaceErrors;
-import org.polypheny.db.protointerface.proto.ConnectionProperties;
 
 public class PropertyUtils {
 

diff --git a/src/main/java/org/polypheny/jdbc/serialisation/ProtoValueSerializer.java b/src/main/java/org/polypheny/jdbc/serialisation/ProtoValueSerializer.java
@@ -8,7 +8,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
-import org.apache.commons.lang3.NotImplementedException;
 import org.polypheny.jdbc.ProtoInterfaceServiceException;
 import org.polypheny.jdbc.ProtoInterfaceErrors;
 import org.polypheny.db.protointerface.proto.ProtoBigDecimal;

diff --git a/src/test/java/org/polypheny/jdbc/QueryTest.java b/src/test/java/org/polypheny/jdbc/QueryTest.java
@@ -5,7 +5,6 @@
 
 import java.sql.Connection;
 import java.sql.DriverManager;
-import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
@@ -15,9 +14,7 @@
 import org.polypheny.jdbc.multimodel.PolyStatement;
 import org.polypheny.jdbc.multimodel.Result;
 import org.polypheny.jdbc.multimodel.Result.ResultType;
-import org.polypheny.jdbc.multimodel.ScalarResult;
 import org.polypheny.jdbc.nativetypes.document.PolyDocument;
-import org.polypheny.db.protointerface.proto.Document;
 
 public class QueryTest {
 
@@ -37,7 +34,7 @@ public void thisOneWorks() throws ClassNotFoundException {
         try (
                 Connection connection = DriverManager.getConnection( "jdbc:polypheny://localhost:20590" );
                 Statement statement = connection.createStatement();
-                ResultSet resultSet = statement.executeQuery( "SELECT * FROM emps" );
+                ResultSet resultSet = statement.executeQuery( "SELECT * FROM emps" )
         ) {
             while ( resultSet.next() ) {
                 // Process the result set...