Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced the auto-Completion #475

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

alyaa999
Copy link

@alyaa999 alyaa999 commented Mar 9, 2024

Summary

Add missing identifiers to the list of suggested names in the auto-completion provided in the SQL query console of the Polypheny-UI.

Fixes #43

ToDo

  • Add Constraints
  • Add Indexes
  • Add Adapters
  • Add QueryInterfaces

modified the response of the
getSchemaTree endpoint to include constraints and indexes for improved the auto-completion provided in the sql query console of the Polypheny-UI
@alyaa999 alyaa999 marked this pull request as draft March 9, 2024 04:00
@alyaa999
Copy link
Author

alyaa999 commented Mar 9, 2024

Hi, @hennlo I need some help,plz
Should I implement adapters and QueryInterface in a separate endpoint ?,

@hennlo
Copy link
Member

hennlo commented Mar 10, 2024

Hi @alyaa999 What do you mean by 'in a sperate endpoint'?

@alyaa999
Copy link
Author

Reference in new

@hennlo I mean that the getSchemaTree method retrieves objects situated under schemas, whereas adapters and the query interface are not part of the schema. Therefore, we should create a new method to specifically return adapters and the query interface, and then add it to the suggestion list in the editor component (Polypheny-UI)
or return adapters and query interfaces with getSchemaTree method ??

@hennlo
Copy link
Member

hennlo commented Mar 10, 2024

@alyaa999 Ah okay I get the question now, thanks for clarifying. Yes indeed a separate method(s) would be desirable since adapters and inetrfaces are not part of any schema 👍

add methid to gell all query interface names
@alyaa999 alyaa999 marked this pull request as ready for review March 11, 2024 18:01
@alyaa999
Copy link
Author

I have a question related to the "getSchemaTree" method. This method accepts a parameter called "depth," and the user interface (UI) sends a request with a depth of 3, indicating schemas, tables, and columns. My question is whether I should adjust this depth to 5 or 4 to express constrains and indexes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include missing identifiers in the list of suggestions of the SQL query console
2 participants