fixed missing transaction handling in tests

polypheny · Dec 3, 2024 · 67650ef · 67650ef
1 parent e54d351
commit 67650ef
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/matrix.yml b/.github/workflows/matrix.yml
@@ -36,5 +36,5 @@ jobs:
                 timeout-minutes: 60
                 run: ./gradlew assemblePlugins -PwithoutpullingUi=true
             -   name: Execute tests
-                timeout-minutes: 45
+                timeout-minutes: 30
                 run: ./gradlew check -PwithoutpullingUi=true
diff --git a/dbms/src/main/java/org/polypheny/db/processing/AbstractQueryProcessor.java b/dbms/src/main/java/org/polypheny/db/processing/AbstractQueryProcessor.java
@@ -283,7 +283,7 @@ private void attachPolyAlgPlan( AlgNode alg ) {
             queryAnalyzer.registerInformation( infoPolyAlg );
 
         } catch ( Exception e ) {
-            e.printStackTrace();
+            throw new GenericRuntimeException( e.getMessage(), e );
         }
 
     }

diff --git a/dbms/src/test/java/org/polypheny/db/polyalg/PolyAlgParsingTest.java b/dbms/src/test/java/org/polypheny/db/polyalg/PolyAlgParsingTest.java
@@ -193,17 +193,19 @@ private static void testQueryRoundTrip( String query, QueryLanguage ql, String n
         assertNotNull( allocation );
         assertNotNull( physical ); // Physical is not yet tested further since it is only partially implemented
 
+        try {
+            transaction.commit(); // execute PolyAlg creates new transaction
+        } catch ( TransactionException e ) {
+            throw new RuntimeException( e );
+        }
+
         // Check that parsing and executing again returns the same result
         String resultFromLogical = executePolyAlg( logical, PlanType.LOGICAL, ql );
         assertEquals( result, resultFromLogical, "Result from query does not match result when executing the logical plan." );
         String resultFromAllocation = executePolyAlg( allocation, PlanType.ALLOCATION, ql );
         assertEquals( result, resultFromAllocation, "Result from query does not match result when executing the allocation plan." );
 
-        try {
-            transaction.commit();
-        } catch ( TransactionException e ) {
-            throw new RuntimeException( e );
-        }
+
     }