Do not allow nullable to be set for primary keys

polypheny · Jan 17, 2025 · 2b41e1d · 2b41e1d
1 parent 8d0a973
commit 2b41e1d
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/dbms/src/main/java/org/polypheny/db/ddl/DdlManagerImpl.java b/dbms/src/main/java/org/polypheny/db/ddl/DdlManagerImpl.java
@@ -1152,6 +1152,11 @@ public void setColumnNullable( LogicalTable table, String columnName, boolean nu
         // Check if model permits operation
         checkModelLogic( table, columnName );
 
+        // Check that column is not part of a primary key
+        if ( catalog.getLogicalRel( table.namespaceId ).getKeys().values().stream().filter( v -> v instanceof LogicalPrimaryKey ).flatMap( v -> v.fieldIds.stream() ).anyMatch( l -> l == logicalColumn.id ) ) {
+            throw new GenericRuntimeException( "Primary key cannot be nullable" );
+        }
+
         catalog.getLogicalRel( table.namespaceId ).setNullable( logicalColumn.id, nullable );
 
         // Reset plan cache implementation cache & routing cache