Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_block_size and set_is_nullspace for linear sovler #74

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

xDarkLemon
Copy link
Contributor

Add set_block_size and set_is_nullspace methods for linear sovler class.
block_size and is_nullspace are used in multigrid solvers.

virtual void set_block_size(int block_size) {}

// If the problem is nullspace for multigrid solvers
virtual void set_is_nullspace(bool is_nullspace) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the nullspace should be a vector

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.54%. Comparing base (9f8a5e1) to head (7536eb3).

Files Patch % Lines
src/polysolve/linear/Solver.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   87.62%   87.54%   -0.09%     
==========================================
  Files          48       48              
  Lines        2045     2047       +2     
==========================================
  Hits         1792     1792              
- Misses        253      255       +2     
Flag Coverage Δ
polysolve 87.54% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teseoch teseoch merged commit 97a92c5 into polyfem:main Mar 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants