Change to use offset-based coordinates #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to support snapping to items that are under different offset parents and uses similar logic to jQueryUI draggable snap. DISCLAIMER: I have not tested this with ghosts or other options besides the options that this plugin adds.
This is not for everyone, but if your objects should never violate their grid settings, then this is for you.
No longer dependent on the plugin loading order either
|
Thank you for this PR, it solved my problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to support snapping to items that are under different offset parents and uses similar logic to jQueryUI draggable snap. This should close #8.
If I get a little time, I'll try to put together a demo of before/after the fix, but I likely won't have time until after the new year.
DISCLAIMER: I have not tested this with ghosts or other options besides the options that this plugin adds. I'm not really sure how to thoroughly test this, so verify all the previous use cases still work before merging.