Get 3.10 build working for Windows #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.10 was previously only in `include`. Quotes were added due to errors introduced through YAML interpreting `3.10` as a Fixnum, which caused `3.1` to be inserted instead.
lambdadog
added a commit
to lambdadog/fugashi-bundled
that referenced
this pull request
Dec 21, 2021
|
Thanks! There may have been a reason for max-parallel of 4 but it shouldn't matter any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the same changes as #50 other than bumping
max-parallelto 5.Willing to revert that if there's some underlying reason for a
max-parallelof 4, but after hunting through the GitHub Actions docs for a bit I couldn't find any particular rate limits on Windows or anything like that so I assumed it was just left over from when there were less Python versions you were supporting.Successful run: https://github.com/lambdadog/fugashi/actions/runs/1603245750 (doesn't include the
max-parallelbump from 4->5, but there should be no difference there other than 5 running at a time rather than 4, and I couldn't be bothered to engineer a way to start another run)Will close #44 once builds are pushed to Pypi.