Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install (Windows x64, Python 3.10) #44

Closed
Skimige opened this issue Oct 28, 2021 · 2 comments · Fixed by #51
Closed

Unable to install (Windows x64, Python 3.10) #44

Skimige opened this issue Oct 28, 2021 · 2 comments · Fixed by #51
Labels
windows Windows support related issues.

Comments

@Skimige
Copy link

Skimige commented Oct 28, 2021

In general, this should be an issue of not having pre-built wheels for Python 3.10.
mecab.h and libmecab.lib cannot be found, causing building errors.

Eventually I noticed that I have to download mecab-msvc-x64.zip 1 and extract to the very specific location recorded in fugashi_utils.py2, in order to build the wheel and install successfully.
(ofc before this, have Build Tools and Windows SDK installed)

What I don't understand is that I have to use this specific (forked) version of mecab, instead of the installer from Official Website (generally because installed ver have subfolders bin and sdk to store dll, h and lib separately). And the hardcoded path does look strange.

fugashi-1.1.1-cp310-cp310-win_amd64.zip

idk if this should be an issue, sorry for any incovenience

Footnotes

  1. https://github.com/polm/fugashi/blob/9ba7b3013680e359aadfe57c2213c7df040d13ca/.github/workflows/windows.yml#L49

  2. https://github.com/polm/fugashi/blob/9ba7b3013680e359aadfe57c2213c7df040d13ca/fugashi_util.py#L18

@polm polm added the windows Windows support related issues. label Oct 29, 2021
@polm
Copy link
Owner

polm commented Oct 29, 2021

Thanks for the reminder, you are correct that the issue here is that wheels for 3.10 haven't been built yet. I will work on adding those.

The Windows build options are designed to work with that particular MeCab build and not really intended for end-users installing from source. The zip we use is a user contribution.

As to why we don't use the official upstream distribution - it hasn't been updated in over five years, I understand the source doesn't build on Windows without modification, and the maintainer basically doesn't respond to issues or pull requests. For example, the user who contributed our Windows build made a PR upstream three years ago, but the maintainer hasn't acknowledged it in any form. I myself have PRs going back over a year before that. So that's why we don't use upstream.

@Skimige
Copy link
Author

Skimige commented Oct 29, 2021

Thanks for explaining 😊
Would it be better to have some installation guidance in README? As manual installation (either from source or a specific version tarball) is the last approach, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Windows support related issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants