Change assetId type in SignerPayloadJSON to HexString

[TarikGul]

closes: #5965

The following is a BREAKING CHANGE

The assetId within the SignerPayloadJSON will now be transmitted as a HexString.

[carlosala]

Hi! Just saw this. I think it could be a great idea to make asHex directly with the option, without making unwrap. Then we have the exact hexstring that will make part of the final extrinsic. What do you think?

[TarikGul]

Hi! Just saw this. I think it could be a great idea to make asHex directly with the option, without making unwrap. Then we have the exact hexstring that will make part of the final extrinsic. What do you think?

Yea totally works, I was on the fence on what to do so this adds some clarity to the decision. So basically undoing the unwrap, and keeping it as an Option<T> but as HexString?

[TarikGul]

There is one annoying thing that I am remembering now, its that the ExtrinsicPayload type in PJS doesn't know how to handle the AssetId when the Option type is passed in as a hex if one wants to reconstruct the extrinsic... I'll need to fix this today.

[carlosala]

I mean, if the type is Option<MultiLocation> it should take the option-prepended hex, right?

[TarikGul]

I totally agree, I am more just babbling to myself before. Unfortunately, i have realized it's not as straightforward as I wished.

[TarikGul]

@carlosala got a working solution, its a bit hacky, but IMO its the safest option, returns the assetId as it should be (Option<TAssetConversion> = Option<MultiLocation | AssetId> for backwards compatibility), and doesn't break any major workflows other than the actual SignerPayloadJSON.

[carlosala]

Sounds good 👍🏻

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.