feat: upgrade to substrate-connect v0.8.4

[kratico]

Upgrade @substrate/connect to v0.8.4 and use the new addChain API.

The addChain API uses the relay chain to instantiate new parachains, for example

const client = createScClient()
const relayChain = await client.addWellKnownChain(input, onMessageForRelay)
const parachain = await relayChain.addChain(input, onMessageForParachain)

Given that the ScProvider is injected a relay chain provider, no changes are needed in the ScProvider public API and it works as before, for example

import { ApiPromise } from "@polkadot/api";
import { ScProvider } from "@polkadot/rpc-provider";
import * as Sc from "@substrate/connect";

import jsonParachainSpec from './myParaChainSpec.json';

const parachainSpec = JSON.stringify(jsonParachainSpec);
const relayProvider = new ScProvider(Sc, Sc.WellKnownChain.westend2);
const provider = new ScProvider(Sc, parachainSpec, relayProvider);

await provider.connect();

// ...

Note: given that ScProvider receives createScClient from @substrate/connect as input to the constructor and that the @substrate/connect API has a breaking change, this is also a breaking change for @polkadot/rpc-provider.

[kratico]

The this.#sharedSandbox!.#chain is not transpiled properly see

I think this is related to this polkadot-js/dev script
https://github.com/polkadot-js/dev/blob/1d7db82109f666dd013d5db04ef2bd6a45f4d74a/packages/dev/scripts/polkadot-dev-build-ts.mjs#L74-L84

[kratico]

cc @jacogr @josepot

[kratico]

as an alternative that is coupled to a polkadot-dev-build-ts.mjs implementation detail, this can be re-written to

    const addChain = this.#sharedSandbox
      ? (async (...args) => {
          const source = this.#sharedSandbox!;
          return (await source.#chain)!.addChain(...args);
        }) as ScType.AddChain
      : this.#wellKnownChains.has(this.#spec as ScType.WellKnownChain)
        ? client.addWellKnownChain
        : client.addChain;

and it will transpile to

        const addChain = this.__internal__sharedSandbox
            ? (async (...args) => {
                const source = this.__internal__sharedSandbox;
                return (await source.__internal__chain).addChain(...args);
            })
            : this.__internal__wellKnownChains.has(this.__internal__spec)
                ? client.addWellKnownChain
                : client.addChain;

[jacogr]

So the dev script implementation can actually be dropped (after we dropped Node 16 last year). The issue is that TSC compiled everything #<id> to WeakMaps for Node 16 compat and it had severe implications for performance. So at best it is/was a horrible workaround.

So the adjustment will be dropped sometime, but no idea when that sometime will be - needs some checks all over when done.

[kratico]

thx for the info @jacogr

I'll re-write it as suggested previously so it's more friendly with this script

[kratico]

re-written in 7df6a77

[jacogr]

Some small CI linting issues - should not be a massive issue to resolve.

[kratico]

eslint-disable because it's checked on line 157

[jacogr]

Seems spot-on. Please just merge master to resolve the yarn.lock conflicts.

The conflicts with the yarn.lock file have been addressed.

[josepot]

Thanks @kratico ! I will try to find out how to create a release.

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.