Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use matrix.runtime.uri for try-runtime tests #530

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jan 8, 2025

Some tests gated with the try-runtime feature have the ability to configure the node URI using some hard-coded defaults, e.g.:

let transport: Transport =
			var("WS").unwrap_or("wss://rpc.dotters.network/kusama".to_string()).into();
...
let transport: Transport =
			var("WS").unwrap_or("wss://kusama-rpc.polkadot.io:443".to_string()).into();
...
let transport: Transport =
			var("WS").unwrap_or("wss://rpc.polkadot.io:443".to_string()).into();
...
let transport: Transport =
			var("WS").unwrap_or("wss://rpc.dotters.network/polkadot".to_string()).into();

Additionally, we have a dedicated runtime uri specified in the runtimes-matrix.json, e.g.,

{
    "name": "polkadot",
    "uri": "wss://try-runtime.polkadot.io:443",
  },
  {
    "name": "kusama",
    "uri": "wss://try-runtime-kusama.polkadot.io:443",
  },

so, let's use those dedicated uris instead of the hard-coded ones.


I came across this issue by accident when Kusama's remote_tests::next_inflation failed with Error while getting storage data here: https://github.com/polkadot-fellows/runtimes/actions/runs/12526255825/job/34938624858?pr=519.
I wasn't sure if it is flaky, missing some keys in the actual block, or just a connection problem, so I also enabled remote-ext=info logs (if the logs are too much, we can switch to remote-ext=warn/error).

remote_tests::next_inflation --- FAILED

failures:

---- remote_tests::next_inflation stdout ----
thread 'remote_tests::next_inflation' panicked at relay/kusama/src/lib.rs:3230:14:
called `Result::unwrap()` on an `Err` value: "Error while getting storage data"
  • Does not require a CHANGELOG entry

@bkchr
Copy link
Contributor

bkchr commented Jan 9, 2025

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) January 9, 2025 21:38
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants