Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply changes since v1.1.0-rc2 import #172

Merged
merged 13 commits into from
Feb 2, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jan 30, 2024

We imported the runtimes into this repo at tag v1.1.0-rc2 but still merged stuff until they got removed in #1731.
This re-applies all changes in that commit range v1.1.0-rc2..bf90cb0b checked in the SDK with
git log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/. Closes #112

Most changes got applied as part of #56, but two were missing:

One open Q since there was a difference between #1291 and #67.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member Author

ggwpez commented Jan 30, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) January 30, 2024 23:14
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@xlc
Copy link
Contributor

xlc commented Jan 30, 2024

Is there a written down identity migration plan? How long will the migration to take? Are UI devs aware of this? Any announcement post? I will either block merge of this PR or the release of the next runtime until those questions are addressed.

However, given that I will most likely going to block the next runtime release due to other reasons (lack of tests), so maybe I will let this pass and just add one more reason to block the next runtime release.

@xlc xlc mentioned this pull request Jan 31, 2024
19 tasks
@joepetrowski
Copy link
Contributor

We don't want to block Identity calls yet. We need at least Polkadot SDK v1.7.0 to start the migration, and we will do Kusama only first. For now, type BaseCallFilter = Everything is fine.

Once we have 1.7.0, I will make a PR with a People Chain runtime and blocking Kusama Identity calls.

Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @joepetrowski comment

relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
ggwpez and others added 5 commits January 31, 2024 20:55
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
This reverts commit fc9da09.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member Author

ggwpez commented Jan 31, 2024

Reverted the identity changes to both runtimes.

CHANGELOG.md Outdated Show resolved Hide resolved
@ggwpez
Copy link
Member Author

ggwpez commented Feb 2, 2024

@xlc PTAL

PS: Nvm looks like the review bot was happy.

@fellowship-merge-bot fellowship-merge-bot bot merged commit 9ce1bbb into main Feb 2, 2024
15 checks passed
@ggwpez ggwpez deleted the oty-reapply-changes branch February 2, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing the Utility::batch_all() method via XCM
6 participants