Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade review-bot #549

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Upgrade review-bot #549

merged 2 commits into from
Jan 21, 2025

Conversation

mutantcornholio
Copy link
Contributor

@mutantcornholio mutantcornholio commented Jan 17, 2025

Upgrading PAPI inside review-bot

  • Does not require a CHANGELOG entry

Upgrading PAPI inside review-bot
@bkontur
Copy link
Contributor

bkontur commented Jan 17, 2025

@mutantcornholio, will you include this paritytech/get-fellows-action#38 as part of this PR?

We definitely need to merge it because, for example, the Review-Trigger job on this PR has been running for over 5 hours: https://github.com/polkadot-fellows/runtimes/actions/runs/12825386773/job/35763245073?pr=549.
image

@github-actions github-actions bot requested review from bkchr, bkontur and xlc January 17, 2025 16:59
Copy link

Review required! Latest push from author must always be reviewed

@mutantcornholio
Copy link
Contributor Author

@bkontur done! Need another approve though

@bkchr
Copy link
Contributor

bkchr commented Jan 20, 2025

@bkchr
Copy link
Contributor

bkchr commented Jan 20, 2025

Also why does it require another review or what is the current error?

@mutantcornholio
Copy link
Contributor Author

Also why does it require another review or what is the current error?

So on PR update, this code requires another review from everyone, who previously approved the PR.
Which for this PR is

{
  "reviewers": [
    "bkontur",
    "bkchr",
    "xlc",
    "seadanda",
    "muharem"
  ]
}

cc/ @xlc @seadanda @muharem

@bkchr
Copy link
Contributor

bkchr commented Jan 20, 2025

So on PR update, this code requires another review from everyone, who previously approved the PR.

But why from all? Wouldn't it be enough for one of them to re-review.

@mutantcornholio
Copy link
Contributor Author

So on PR update, this code requires another review from everyone, who previously approved the PR.

But why from all? Wouldn't it be enough for one of them to re-review.

Yeah, doesn't make sense for me as well. I can try searching for paper trail, to see why is it like this, or we can just change it (separately from these changes).

@bkchr
Copy link
Contributor

bkchr commented Jan 20, 2025

Yeah, doesn't make sense for me as well. I can try searching for paper trail, to see why is it like this, or we can just change it (separately from these changes).

Sounds like it got mixed up. In Polkadot-sdk we only require the approval of one person again.

@bkchr bkchr enabled auto-merge (squash) January 21, 2025 13:57
@mutantcornholio
Copy link
Contributor Author

@bkchr I've created an issue about this: #557

@bkchr bkchr disabled auto-merge January 21, 2025 16:14
@bkchr bkchr merged commit a9669a2 into polkadot-fellows:main Jan 21, 2025
56 of 57 checks passed
@mutantcornholio mutantcornholio deleted the patch-1 branch January 22, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants