Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade papi and apply suggestion from papi team #140

Closed
1 task
bkontur opened this issue Jan 16, 2025 · 1 comment · Fixed by #141
Closed
1 task

Upgrade papi and apply suggestion from papi team #140

bkontur opened this issue Jan 16, 2025 · 1 comment · Fixed by #141
Assignees
@mutantcornholio

Comments

@bkontur
Copy link

bkontur commented Jan 16, 2025 •
edited
Loading

Relates to: polkadot-api/polkadot-api#918 (comment)

Looking at the code of https://github.com/paritytech/review-bot I can see that it's using some ancient versions of polkadot-api and smoldot, please update the dependencies of the review-bot and try again.

Also, when using smoldot, it's important to upgrade the chainspecs frequently (~once a month), so that the lightSyncState stays up to date, this is important for 2 different reasons:

1. The initial sync is much faster when the chainspec is up to date.

2. It prevents long-range attacks

We periodically publish patches of polkadot-api with the an updated version of the different chainspecs, so keeping papi up to date does the trick.

TODO

  • upgrade Fellows repo with new version when upgraded
@bkontur bkontur mentioned this issue Jan 16, 2025
Closed
@mutantcornholio mutantcornholio self-assigned this Jan 16, 2025
@mutantcornholio mutantcornholio mentioned this issue Jan 16, 2025
Merged
mutantcornholio added a commit to paritytech/polkadot-sdk that referenced this issue Jan 17, 2025
@mutantcornholio
review-bot upgrade
a545f8d 
Upgrading PAPI in review-bot: paritytech/review-bot#140
@mutantcornholio mutantcornholio mentioned this issue Jan 17, 2025
Merged
@mutantcornholio
Copy link
Contributor

polkadot-fellows/xcm-format#72
polkadot-fellows/runtimes#549
paritytech/polkadot-sdk#7214

github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue Jan 17, 2025
@mutantcornholio
review-bot upgrade (#7214)
c2531dc 
Upgrading PAPI in review-bot:
paritytech/review-bot#140
pgherveou pushed a commit to paritytech/polkadot-sdk that referenced this issue Jan 17, 2025
@mutantcornholio @pgherveou
review-bot upgrade (#7214)
a8be8e0 
Upgrading PAPI in review-bot:
paritytech/review-bot#140
Nathy-bajo pushed a commit to Nathy-bajo/polkadot-sdk that referenced this issue Jan 21, 2025
@mutantcornholio @Nathy-bajo
review-bot upgrade (paritytech#7214)
f674feb 
Upgrading PAPI in review-bot:
paritytech/review-bot#140
Nathy-bajo pushed a commit to Nathy-bajo/polkadot-sdk that referenced this issue Jan 21, 2025
@mutantcornholio @Nathy-bajo
review-bot upgrade (paritytech#7214)
39e64db 
Upgrading PAPI in review-bot:
paritytech/review-bot#140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mutantcornholio mutantcornholio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PAPI upgrade paritytech/review-bot
2 participants
@mutantcornholio @bkontur